Forum Replies Created
- AuthorPosts
- Jamie O’ReillyParticipant
Pleased to hear it. Yes be careful it doesn’t get overwritten – you might want to keep a copy somewhere.
Think I saw somewhere you were asking about Per Product Shipping as well. We’ve gone down this route recently. Happy to share thoughts if helpful.
Jamie
Jamie O’ReillyParticipantHi Steve
Sorry for not getting back to you sooner. Did adding the new code resolve it for you?
We found another bug as well that was messing up the destination of the shipping fee and the commission in Stripe so had to hack that too.
Jamie
Jamie O’ReillyParticipantHi
Stripe should be able to tell you if your accounts are disconnecting so quickly that it must be due to your platform sending two requests in close succession. It was this feedback from Stripe that enabled us to spot that this issue was happening but in our case it was definitely caused by the conflict between KC and Storefront. I think our hack is very specific to this issue and so won’t help you unless you’re having this exact same issue. Think you should check first.
Jamie O’ReillyParticipantHi
Sorry I should have explained a bit more about that hack. My developer found this to be the offending code that was causing us to get a missing source error.
if( ! wcfmmp_stripe_split_pay_form.hasSource() && ! wcfmmp_stripe_split_pay_form.hasToken() ) {
He explained that when you submit the form this code runs. The second time we still have a token, so it skips doing the stripe setup however because it skips we don’t get a source. The && should be || and that would mean if either are missing it would redo the setup.
This is where the offending code is located
wp-content/plugins/wc-multivendor-marketplace/assets/js/gateway/stripe.js
We left the original in there but commented it out and added the code I attached before in this thread. I have passed this on to the devs at WC Lovers but I appreciate they need to check it out fully first themselves and so you may wish to wait to get their confirmation and the update but thought I should post it anyway.
It was nothing to do with PEr Product Shipping – that brought it’s own, even more challenging problems.
Jamie
Jamie O’ReillyParticipantUpdate for anyone thinking of using this plugin. It’s not quite fully compatible as it doesn’t send the shop vendor information to Stripe and so Stripe cannot allocate any money to your vendors. It can therefore cause chaos. We have a fix though although even this isn’t quite 100%.
Jamie
November 5, 2019 at 1:13 am in reply to: Shipping going to admin not vendor in per product shipping #90647Jamie O’ReillyParticipantSorry Carlos, don’t know the answer to that one.
jamie
Jamie O’ReillyParticipantWe’ve now discovered that it’s any missing field or mistake made by the customer when at checkout. The second form submission – which is what it is, to Stripe, is missing crucial information. We have implemented a hack which prevents the form content being submitted at all unless it is all completed correctly.
Here wp-content/plugins/wc-multivendor-marketplace/assets/js/gateway/stripe.js
we added the following – see attached.
Attachments:
You must be logged in to view attached files.Jamie O’ReillyParticipantYes there’s Per Product Shipping plugin but don’t go there yet as there are currently problems that need to be resolved.
Jamie O’ReillyParticipantDon’t know if it’s the same with you but this has only happened since we moved to the Per Product Shipping plugin. We’ve found that the first issue appears to be that if customers forget to tick the ‘agree to website terms and conditions’ box and have to be reminded and then tick it, not all of the required information is sent to Stripe which makes the payment fail or at least mess up. We are going to try and write some javascript so that the browser prevents the initial submission if the checkbox hasn’t been checked. That should be a workaround for the first problem but there is though a second problem which is perhaps worse. Those payments that do go through send shipping fee that’s been taken, often to the admin and not the vendor. Sometimes it’s the reverse, the shipping fee goes to the admin but the product payment goes to the vendor – not both to the vendor as it should even though it’s clearly set as a global rule to send the payment minus the commission and the shipping to the vendor. My developer thinks it could be a situation where two messages are racing against each other and only the winning one goes through. It’s beyond my understanding and I’m praying he finds the answer because at the moment it’s chaos. It’s as if the Per Product Shipping plugin just doesn’t recognise the Stripe Connect system at all.
Would be great if the WC Devs could get involved as this is proving to be a fatal flaw at the moment and creating total chaos.
Jamie O’ReillyParticipantWe are having this problem too – please can you tell us what the fix was?
Jamie O’ReillyParticipantSorry for the delay in replying. We managed to write a hack that steers the second call away to the index.php and kills it. It’s a good temporary fix but ultimately solution is to get rid of KC. Can supply details of the hack – probably Github or similar might be best place.Interested?
Jamie O’ReillyParticipantSorry for the delay in replying. We managed to write a hack that steers the second call away to the index.php and kills it. It’s a good temporary fix but ultimately solution is to get rid of KC. Can supply details of the hack – probably Github or similar might be best place.Interested?
Jamie O’ReillyParticipantSwitched and used the Per Product Shipping solution. Better option. Didn’t realise it was compatible because it wasn’t listed in the compatible plugins page.
Jamie O’ReillyParticipantWe are having the same issue now with add ons too. Once we set an add on we cannot remove it.
Thank youJamie O’ReillyParticipantWe have found that a conflict between King Composer and Storefront was causing the request to be sent to stripe twice causing stripe account ot be disconnected.
Jamie O’ReillyParticipantThis reply has been marked as private.Jamie O’ReillyParticipantYou have said before that if a vendor wants to limit shipping to a zone, then they simply click on the ‘limit zone location’ box and add the locations. However, for us, no locations appear when you begin to type and Europe, for example, has 46 locations. In that situation how does a shop vendor who doesn’t want to ship to Europe at all, prevent their products from being added to customers carts with no shipping fee attached. They don’t want to ship to Europe, even though other shop vendors might want to.
Very happy to pay for help here but really need some help.
Thanks
Jamie O’ReillyParticipantThis reply has been marked as private.Jamie O’ReillyParticipantWe hvae an issue with stripe not onboarding vendors too. Their accounts say connected but they aren’t apearing in admin stripe account.
What would packing slip have to do with it please?
Jamie O’ReillyParticipantHow would you do this in wp > products as I don’t seem to be able to filter by vendor there. Sorry if I am missing something obvious?
Jamie O’ReillyParticipantPlease, please, please can you come up with a solution : )
Jamie O’ReillyParticipantthe other screenshot
Attachments:
You must be logged in to view attached files.Jamie O’ReillyParticipantCan you help please?
Jamie O’ReillyParticipantWe have set it there as well but they are still somehow managing to get into other categories – am I missing a setting?
Thank you : )Attachments:
You must be logged in to view attached files.Jamie O’ReillyParticipantThanks for your help. We’ve used this suggested method.
- AuthorPosts